Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #405 to MORYX 8 #415

Merged
merged 14 commits into from
May 6, 2024
Merged

Conversation

seveneleven
Copy link
Contributor

@seveneleven seveneleven commented May 6, 2024

Port #405 to MORYX 8

* `npm run dev` did not succeed anymore, so the `contentBase` needed to be changed
  to `static`.
* Deprecated `--watch` option is now removed from `dev` script.
It was missing and lead to errors when trying to build the app.
These changes also include a fix for where the previous version could mark
multiple list items as active if they were similar (starting with same string).
Now, the path is checked for being a sub path, rather than just starting with
the same string.

Also removes unused `TreeMenu`.
This adds Material UI to the module list (navigation) and the module overview.
`SectionInfo` and `ModuleInfoTile` got created for code reuse.

The Notifications modal got removed in exchange for a collapsible list, which
can be browsed like a log file.
Reactstrap hasn't just been replaced by Material UI components here. It seemed
easier to slightly change the UI than adjusting all the styling to preserve the
previous design:

* The entry editors 'open' and 'expand/collapse' buttens have been replaced by
  a tree navigation. By removing the whole table, the informational column for
  item titles and descriptions has moved into the input fields and tooltips.
* The 'Save and restart' and 'Save' buttons have been merged into a
  `DropDownButton` to reduce 'primary' actions

Also fixes some problems with input change events.
This also fixes an issue with drop downs being stuck.

For the migrations and setups, the issues with drop downs have been fixed by
removing the drop downs at all and providing a list of available items instead.
Every list item has an 'action button' for the item (migration or setup) to be
executed. So that there is no state anymore to be cached.

Also:

* Correct or 'similar' configurator will be preselected, even on a version
  mismatch
* UI updates properly, when switching between database contexts
* If the database name is `null`, the context name will be used/prefilled as
  the default
By switching to Material UI, depending on reactstrap and related packages is
not required anymore. Also, all the custom css definitions are obsolete.

This stops styles from being overwritten by parent UIs and vice versa.
@seveneleven seveneleven added bug Something isn't working enhancement New feature or request labels May 6, 2024
@seveneleven seveneleven self-assigned this May 6, 2024
@seveneleven seveneleven merged commit fb24d01 into dev May 6, 2024
8 checks passed
@seveneleven seveneleven deleted the update/replace-reactstrap-by-material-ui branch May 6, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants